230 causes crashes. I believe that problems start when data contains no suitable meta attributes, in which case self.image_attr is set to None - although combo does not have this option. This image_attr is nevertheless saved as context. Such context then matches any context and overrides the heuristics. As result, the combo that controsl image_attr shows the first item, while image_attr is actually None. Reselecting the attribute shows images ...
Once image_attr == None is saved in context, the widget will crash on any new data.
While fixing this, we should probably fix the corresponding model: the model takes only meta attribute, but the code that sets the default searches among all attributes. We should decide whether to use metas or all attributes. In the former case, we need to include @markotoplak's fixes for context handlers.
230 causes crashes. I believe that problems start when data contains no suitable meta attributes, in which case
self.image_attris set toNone- although combo does not have this option. Thisimage_attris nevertheless saved as context. Such context then matches any context and overrides the heuristics. As result, the combo that controslimage_attrshows the first item, whileimage_attris actuallyNone. Reselecting the attribute shows images ...Except that the widget crashes even earlier. https://github.com/biolab/orange3-imageanalytics/pull/230/files#diff-f1387607314e9d4d0902ec7b8bf2987bf2faa37970f60d834865538719c3957bR353 calls
column_data_as_qurlwhich returns[]ifimage_attrisNone, which breaksassert len(self.data) == len(urls).Once
image_attr == Noneis saved in context, the widget will crash on any new data.While fixing this, we should probably fix the corresponding model: the model takes only meta attribute, but the code that sets the default searches among all attributes. We should decide whether to use metas or all attributes. In the former case, we need to include @markotoplak's fixes for context handlers.