Network Explorer: Replace (crashing) threads with ConcurrentMixin

janezd commented 1 year ago

Issue

Fixes #238. Fixes #219. Fixes #190.

Description of changes

Use ConcurrentMixin instead of (incorrect) threads created in the widget code.
Change the FR to report progress in 0.5 second intervals instead of on certain number of steps. This makes it smoother (the points no longer have essential tremor) and increases responsiveness (at least in cases I tried).
Fix: convert dtype to np.int32, as expected by Cython code. The network can, in principle, have edges in, e.g. np.int64. (The bug was discovered when Network of Neighbors had return a net with such dtype.)
Several lint-related changes (including one actual fix)

Includes

[X] Code changes

codecov-commenter commented 1 year ago

Codecov Report

Attention: 52 lines in your changes are missing coverage. Please review.

Comparison is base (9279386) 73.76% compared to head (d041e73) 74.10%.

Files	Patch %	Lines
orangecontrib/network/widgets/OWNxExplorer.py	53.68%	44 Missing :warning:
orangecontrib/network/network/layout/__init__.py	0.00%	8 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #261 +/- ## ========================================== + Coverage 73.76% 74.10% +0.33% ========================================== Files 21 21 Lines 2977 3000 +23 ========================================== + Hits 2196 2223 +27 + Misses 781 777 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

VesnaT commented 8 months ago

When I disconnect the input, comboboxes and outputs are not reset.

biolab / orange3-network