Update learners to work with new Orange3 versions

biolab / orange3-recommendation

🍊 :thumbsdown: Add-on for Orange3 to support recommender systems.

Other

25 stars 15 forks source link

Update learners to work with new Orange3 versions #14

Open robertcv opened 5 years ago

robertcv commented 5 years ago

Issue

Fixes #8, #9

Description of changes

Add ConcurrentMixin which moves computation on thread and fix old input/output style.

Includes

[X] Code changes
[ ] Tests
[ ] Documentation

lanzagar commented 5 years ago

Have you considered Orange.widgets.utils.concurrent.ConcurrentMixin as an alternative to OWHeavyLearner (or maybe its base)?

robertcv commented 5 years ago

@lanzagar Changed code to use ConcurrentMixin. Take a look.

robertcv commented 5 years ago

@VesnaT I combined the functionality into a new base class. This could be then a starting point for how to integrate it into OWBaseLearner but this is beyond this PR (and is probably not trivial because of the different callbacks). The same goes for the resuming of learning.