Learners should not hold references to widgets

[astaric]

When learners are used with Tests & Score widget, they get deep_copied, which is implemented in python as pickling and unpickling. If a learner holds a reference to a widget, this currently results in a crash, as widgets cannot be pickled. But even if they could be, this would result in an unexpected behaviour where we would end up with two instances of the same widget, but only one node on a canvas.

See https://github.com/biolab/orange3/issues/2793

[bernardofn]

Any idea when this will be solved?

[astaric]

Sadly, no.

This add-on has been developed as a GSoC 2016 project but has not been maintained since. If you want, you can take a look at the code base and try to submit a pull request to fix the problem.

The simplest fix would be to constructs learners in widgets without callbacks, avoiding the problem alltogether.

[bernardofn]

Thanks Anze.

I will try to work first with the baselines.

And maybe get metrics like the R2 and RMSE from a script.

Best regards,

Bernardo

Enviado do Outlookhttp://aka.ms/weboutlook

---

De: Anže Starič notifications@github.com Enviado: quinta-feira, 19 de abril de 2018 02:21 Para: biolab/orange3-recommendation Cc: bernardofn; Comment Assunto: Re: [biolab/orange3-recommendation] Learners should not hold references to widgets (#9)

Sadly, no.

This add-on has been developed as a GSoC 2016 project but has not been maintained since. If you want, you can take a look at the code base and try to submit a pull request to fix the problem.

The simplest fix would be to constructs learners in widgets without callbacks, avoiding the problem alltogether.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/biolab/orange3-recommendation/issues/9#issuecomment-382613727, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AcEu4bCEcls0dpX1FpjqUOwOccfa5wqGks5tqB7NgaJpZM4QpcVZ.