Closed jurijsteblaj closed 5 years ago
Merging #304 into master will decrease coverage by
<.01%
. The diff coverage is0%
.
@@ Coverage Diff @@
## master #304 +/- ##
==========================================
- Coverage 61.36% 61.35% -0.01%
==========================================
Files 28 28
Lines 6264 6265 +1
==========================================
Hits 3844 3844
- Misses 2420 2421 +1
Impacted Files | Coverage Δ | |
---|---|---|
...gecontrib/single_cell/widgets/contingency_table.py | 0% <0%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update bcf36ed...327dfe6. Read the comment docs.
I now use a constant value instead of storing self.horizontalHeader().defaultSectionSize()
.
You can probably squash these two commits into one before merging.
Issue
Fixes #303
Description of changes
This solution here is quite ugly. I don't know how to fix this properly.
If we input the iris dataset, the longest of the labels at the top has a size hint of (29, 98) after calling
self.resizeRowToContents(1)
. But ifself.horizontalHeader().setDefaultSectionSize(self.cell_size)
is called before that (the problem can occur at the next call of this method) with value 30, the size hint will be (46, 73). The other two labels have shorter and wider size hints as well. The delegate used isCircleItemDelegate
, which uses methods fromgui.VerticalItemDelegate
for those labels.The current fix stores the default
self.horizontalHeader().defaultSectionSize()
, which seems to be 100, and applies it before the call toself.resizeRowToContents(1)
. After that it sets the value again toself.cell_size
.Includes