search

biolab / orange3-timeseries

🍊 :chart_with_upwards_trend: Orange add-on for analyzing, visualizing, manipulating, and forecasting time series data.
Other
62 stars 41 forks source link

Fix Seasonal Adjustment test #141

Closed ajdapretnar closed 4 years ago

ajdapretnar commented 4 years ago
Issue

Seasonal Adjustment test was calling the spinbox incorrectly.

Description of changes

Call actual spinbox values.

Includes
ajdapretnar commented 4 years ago

That said, the issue here is also that the automatic adjustment of a spinbox when there are not enough seasons doesn't update n_periods parameter. Which it probably should.

codecov-io commented 4 years ago

Codecov Report

Merging #141 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   69.55%   69.55%           
=======================================
  Files           7        7           
  Lines         795      795           
  Branches      131      131           
=======================================
  Hits          553      553           
  Misses        191      191           
  Partials       51       51

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f4f7934...fa9be76. Read the comment docs.

ajdapretnar commented 4 years ago

Yeah, instead of changing the test, I've decided for saving the spinbox value in n_periods parameter. As appropriate.

irgolic commented 4 years ago

This will be fixed in orange-widget-base by https://github.com/biolab/orange-widget-base/pull/110.