biolab / orange3-timeseries

🍊 :chart_with_upwards_trend: Orange add-on for analyzing, visualizing, manipulating, and forecasting time series data.

Other

62 stars 41 forks source link

[ENH] Use non-deprecated ARIMA implementation #178

Closed markotoplak closed 2 years ago

markotoplak commented 3 years ago

Issue

177

Description of changes

I tried doing minimal changes to use a non-deprecated implementation. Works, but there is a problem: the results I obtain are different. See the test... Is this expected?

If we can not solve this is quickly I suggest pinning statsmodels <= 0.13 and making a release.

Includes

[X] Code changes
[X] Tests
[ ] Documentation

janezd commented 2 years ago

@markotoplak, your changes seem OK. I tried to reconstruct the history of changes in ARIMA to check that your code is equivalent to what we had before ... but I'm giving up. I say we merge this.