Closed janezd closed 1 year ago
Base: 73.76% // Head: 74.74% // Increases project coverage by +0.98%
:tada:
Coverage data is based on head (
6d2c03d
) compared to base (0d5716e
). Patch coverage: 94.40% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@VesnaT was showing me her "focus" bug.
I know I am old-fashioned, but if I navigate with Tab
or shift+Tab
I would not expect any changes in the widget's state. Therefore, I am against the current on-focus behaviour. Instead, we could make the same action only if the line edit is clicked.
That would also likely avoid the bug Vesna is getting. :)
@markotoplak, I agree. I also thought there's a signal clicked
, but alas not. QCheckbox
has it, QLineEdit
doesn't.
@VesnaT, could you please try replacing focusInEvent
with mousePressEvent
and see whether this resolves the problem?
@janezd, if this works, a proper event for the test call (which you don't want to have to assemble again) is
edit.mousePressEvent(QMouseEvent(
QMouseEvent.MouseButtonPress,
QPointF(3, 3), edit.mapToGlobal(QPoint(3, 3)),
Qt.LeftButton, Qt.LeftButton, Qt.NoModifier))
Issue
TimeSeries
.get_column
intoTable
if necessary, and useget_column
instead ofget_column_view
.Timeseries.from_data_table
and reimplementingcopy
and__getitem__
.Description of changes
This changes the previous functionality because it always adds a variable. Should the user have an option to remove it? On the other hand, one could consider previous functionality broken because it allowed constructing a
TimeSeries
withtime_variable == None
(which was in fact unexpected and broke some widgets).Includes