search

biolab / orange3-timeseries

🍊 :chart_with_upwards_trend: Orange add-on for analyzing, visualizing, manipulating, and forecasting time series data.
Other
62 stars 40 forks source link

[FIX] ARIMA - remove use_exog #252

Closed PrimozGodec closed 1 year ago

PrimozGodec commented 1 year ago
Issue

In https://github.com/biolab/orange3-timeseries/pull/235 Use exogenous data was removed. I guess it was removed since widget can use them always when they are present on the input and not use them when their input is None. This change didn't remove the self. use_exog variable and its use. It can cause an error in model fitting when it is still remembered in Orange's setting as True. The other error is that it is still passed to the model even if it cannot be set.

Description of changes

Remove self. use_exog and pass True to the model if exog data on input, False otherwise. Simple tests.

Includes
PrimozGodec commented 1 year ago

Failing tests should be fixed in https://github.com/biolab/orange3-timeseries/pull/253