search

biolab / orange3-timeseries

🍊 :chart_with_upwards_trend: Orange add-on for analyzing, visualizing, manipulating, and forecasting time series data.
Other
62 stars 40 forks source link

[FIX] Temporarily skip installing yfinace and pandas_datareader for MacOS #262

Closed PrimozGodec closed 9 months ago

PrimozGodec commented 9 months ago
Issue

Fixes (partially) #261

Description of changes

Until LXML provides wheels for ARM MacOS, I will skip the installation of yfince and pandas_datareader. Both of them require lxml. It will affect the Yahoo widget, which will not be shown on MacOS. It is just a temporary solution and hopefully can be reverted soon. I am helping lxml to provide the missing wheels.

Includes
codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a752b99) 77.92% compared to head (780fbf7) 77.92%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #262 +/- ## ======================================= Coverage 77.92% 77.92% ======================================= Files 28 28 Lines 4511 4511 Branches 612 612 ======================================= Hits 3515 3515 Misses 861 861 Partials 135 135 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ajdapretnar commented 9 months ago

Works for me.

kraaidelft commented 9 months ago

What is 'skip the installation of yfince and pandas_datareader'? Never seen those. But I found a 'etree_lxml.py' in the IBM SPSS folder. Removed the whole SPSS world from my Mac and … Bingo ! Widget Timeseries is installed now on a Mac with an M1. Thanks !

PrimozGodec commented 9 months ago

What is 'skip the installation of yfince and pandas_datareader'? Never seen those.

The problem that we currently have regarding time series on MacOS is that the library lxml that gets installed while installing the add-on does not provide wheels for Apple silicon (ARM), which means that lxml would need to build on the user's computer (user would need to have appropriate compilers). Installation fails if the user doesn't have compilers (which is most Orange users). This library is not a direct requirement of orange3-timseries but is a requirement of libraries yfinance and pandas_datareader that the Yahoo widget requires. We decided to temporarily skip installing those two libraries to solve the problem, so LXML doesn't need to be installed.

Since those two requirements are missing currently MacOS users will not see the Yahoo widget unless they install yfinance and pandas_datareader library manually (with pip install pandas_datareader yfinance.

This issue affects only MacOS users on Windows; anything should be all right.