biolab / orange3

🍊 :bar_chart: :bulb: Orange: Interactive data analysis
https://orangedatamining.com
Other
4.85k stars 1.01k forks source link

Orange3.25.0 Select columns does not apply filter on output #4759

Closed Jmolenberghs closed 4 years ago

Jmolenberghs commented 4 years ago

Select columns does not apply filter on output

Select Columns widget when 1 column is selected connected to a Venn Diagram widget should give the number of unique values of said column, however all rows are returned.

To Reproduce

  1. Connect "File" widget (eg Iris dataset) to "Select Columns" widget
  2. Open 'Select columns' widget
  3. Select "petal width" as feature, "iris" as target variable
  4. Connect "Venn Diagram"-widget to Select Columns"-widget
  5. Open "Venn Diagram"-widget
  6. See incorrect data (150)

Orange version: 3.25.0

Expected behavior In previous versions it would give 27 instances in step 6

Screenshots in orange3.25.0: screenshot_venndiagram

Expected behavior in orange3.24.1: image

Operating system: Windows 10 Ubuntu 19.10

Additional context NA

janezd commented 4 years ago

Select Columns selects and rearranges columns (http://docs.biolab.si/3/visual-programming/widgets/data/selectcolumns.html) It doesn't do anything related to unique values.

Venn Diagram shows sets whose elements are rows, identified by suitable (key-like) identifiers (which are not present in this data). (https://orange3.readthedocs.io/en/3.5.0/widgets/visualize/venndiagram.html)

Everything works as expected.

There's a Unique widget in the prototype add-on. It may not be complete and fully stable and mature, but might help you.

Jmolenberghs commented 4 years ago

Ok, but why did the same sequence give this venn diagram in orange3.24.1? image

janezd commented 4 years ago

Venn has been largely rewritten. This must had been one of its bugs. It wasn't supposed to do that.