biolab / orange3

🍊 :bar_chart: :bulb: Orange: Interactive data analysis
https://orangedatamining.com
Other
4.85k stars 1.01k forks source link

Heat Map: don't show bow attributes if flag hidden=True #5306

Closed ajdapretnar closed 2 years ago

ajdapretnar commented 3 years ago

Keep it as is.

ajdapretnar commented 3 years ago

What do you think @PrimozGodec?

PrimozGodec commented 3 years ago

Hmm, it is a difficult one. On one side it would be nice to be consistent and remove hidden attributes. On the other side, what if someone wants to see embeddings on the heatmap. Then she/he would need to go through each attribute in the edit domain and change hidden attribute to False.

Another solution would be to remove hidden attributes from the heatmap and add a checkbox to the embedding widgets same as in the Bag of words widget.

I am actually more for this second option. This way we give the user the option to hide some attributes and still he can check embeddings with the heatmap.

ajdapretnar commented 3 years ago

Right, I forgot embeddings are also hidden. Yes, this would make sense - adding a checkbox to Doc Emb would make the most sense. And of course hiding hidden attributes in Heat Map.

ajdapretnar commented 3 years ago

I think this was the proposed solution:

ajdapretnar commented 2 years ago

Partially fixed in https://github.com/biolab/orange3-text/pull/852. The rest is fixed in https://github.com/biolab/orange3/pull/6000.