Gradient Boosting kills Orange

biolab / orange3

🍊 :bar_chart: :bulb: Orange: Interactive data analysis

https://orangedatamining.com

Other

4.85k stars 1.01k forks source link

Gradient Boosting kills Orange #5599

Closed VesnaT closed 3 years ago

VesnaT commented 3 years ago

What's wrong?

Orange unexpectedly terminates when tuning Gradient Boosting (xgboost) parameters.

Log: log.txt

How can we reproduce the problem?

Open the attached workflow.
Keep clicking (e.g. 10 clicks per second) the Apply button in the Gradient Boosting widget.

xgboost_crash.ows.zip

What's your environment?

Operating system: macOS Catalina
Orange version: master
How you installed Orange: with pip from source

markotoplak commented 3 years ago

Can not replicate on macOS Mojave with the 3.30 test build (https://dev.azure.com/markotoplak/markotoplak/_build/results?buildId=25&view=artifacts&pathAsName=false&type=publishedArtifacts)

Can not replicate on my Linux system.

PrimozGodec commented 3 years ago

I cannot replicate it on Big Sur (11.5.2) with test build and neither with development version.

markotoplak commented 3 years ago

@VesnaT can replicate it reliably both with 3.30 test build (running on Qt 5.15) and 3.29.3 (current official build, uses Qt 5.12). She also updated libomp and it did not help.

markotoplak commented 3 years ago

She seems quite proud of her three-clicks-to-crash average.

janezd commented 3 years ago

The crash, which occurs in thread 35 in your log, has xgboost::DMatrix* xgboost::DMatrix::Create<xgboost::data::DenseAdapter> on the stack, which looks like the same function that crashed in tests on Mac. If this is indeed the same bug, #5613 should provide a temporary workaround and the next release of xgboost should contain a fix.

VesnaT commented 3 years ago

The temporary fix works for me.