biolab / orange3

🍊 :bar_chart: :bulb: Orange: Interactive data analysis
https://orangedatamining.com
Other
4.85k stars 1.01k forks source link

File can not read Google Sheets #5723

Closed ajdapretnar closed 2 years ago

ajdapretnar commented 2 years ago

What's wrong?

Google Drive apparently changed the API to retrieve Google Sheets. Now, one cannot just enter sharable link to load the data (Read error).

We should check the API and see whether we can fix this so that one can easily load the data from the link.

How can we reproduce the problem?

Try to load any data from Google Sheets via link.

What's your environment?

JakaKokosar commented 2 years ago

The issue here is that since https://github.com/biolab/orange3/commit/62a7605ba4c08db89703838ec9e767cc400a7a1a we encode URLs, and google docs services don't like this.

Plain URL works fine: https://docs.google.com/spreadsheets/d/1PJhmH0X_N7hZn03le5J70E4IKL4LiqAZenlhg2kWWUU/edit#gid=0

Encoded URL cannot be found: https://docs.google.com/spreadsheets/d/1PJhmH0X_N7hZn03le5J70E4IKL4LiqAZenlhg2kWWUU/edit%23gid%3D0

This seems to be specific to google services because Dropbox links and links to biolab servers work fine: http://file.biolab.si/text-semantics/data/elektrotehniski-vestnik-clanki/detektiranje-utrdb-v-%C5%A1ahu-.txt

One solution is to do an additional check for 'docs.google.com' URLs and skip encoding entirely. Any other ideas?

lukasholovsky commented 2 years ago

Hi, Lukas from AlgOps.com here.

This issue is probably not based on API because in older versions of Orange (3.27 respectively) it worked even though it didn't work in newer versions. A

@JakaKokosar also your plain URL doesn't work fine - I tried this several minutes ago and it returns the same error even though I am able to look at the Sheet in the browser.

Please can you speed up on this issue since a big portion of our customers can't use both AlgOps and Orange due to this?

Thanks!

markotoplak commented 2 years ago

The bug is there from merging #5412. So this bug may stem from:

@lukasholovsky, if the functionality is important for you, consider making a PR.