biolab / orange3

🍊 :bar_chart: :bulb: Orange: Interactive data analysis
https://orangedatamining.com
Other
4.85k stars 1.01k forks source link

Color file not correctly loaded? #5742

Closed kaimikael closed 2 years ago

kaimikael commented 2 years ago

What's wrong?

I may be misunderstanding how this is supposed to work, on the other hand I will argue that the help window for Color does not show the SAVE/LOAD/RESET buttons and accordingly does not explain them :-) (So the help page, at least, would need to be updated.)

Anyway, in the attached workflow I have a widget Color in which I set the colours for Japan and United States, respectively. I have pressed SAVE in order to create a file GroupedChartsColourMap.colors. In another branch of the workflow I want to reuse these colour settings, so in the widget Color (1) I have pressed LOAD in order to read the saved colours. However, this does not seem to affect the colour settings for Japan and United States in that widget, they retain their defaults.

My assumption was that the SAVE/LOAD pair allows me to reuse colour maps in different workflows, but this does not happen?

How can we reproduce the problem?

The workflow, data, and colors file are attached. If you open the Color widget, you see the intended setting of country colours. If you open Color (1), press LOAD and load the GroupedChartsColourMap.colors file, you can see that the colour settings in that widget are not affected.

What's your environment?

ColourMap.zip

janezd commented 2 years ago

Rename "Country" and the country and it will work. :)

But a little warning would be nice nevertheless. I will change the widget to warn the user about ignored variable definitions ("country", in your case), but not about the values.

kaimikael commented 2 years ago

D'oh! Two bugs of my own making! Sorry about that.
But an update of the manual to cover the colour map buttons would be nice at some point.