search

biolab / orange3

🍊 :bar_chart: :bulb: Orange: Interactive data analysis
https://orangedatamining.com
Other
4.85k stars 1.01k forks source link

Distances: wrong error in Mahalanobis #6166

Closed ajdapretnar closed 2 years ago

ajdapretnar commented 2 years ago

What's wrong?

When selecting Mahalanobis distance and feeding the widget more than 1000 rows/columns, the widget should (according to source code, L186) raise an error.

  1. For Rows, it does not raise an error at all and proceeds with computation.
  2. For Columns, it raises an error, but the error says "rows" in the text. The axis number is wrong.

How can we reproduce the problem?

Datasets (wine quality) - Distances.

ajdapretnar commented 2 years ago

Correction, this only concerns columns computation, where the size of the matrix should be <100 rows if there are more than 1000 columns. In theory. However, I can use Mahalanobis just fine on 1001x1001 data set.