biolab / orange3

🍊 :bar_chart: :bulb: Orange: Interactive data analysis
https://orangedatamining.com
Other
4.85k stars 1.01k forks source link

Feature Statistics - open issues #6173

Closed lanzagar closed 1 year ago

lanzagar commented 2 years ago

After PR #6158 there are some open issues left that should be discussed:

wvdvegte commented 2 years ago

If it doesn't require a lot of effort, I think computing mode for numeric variables makes sense - especially if they are integers. And even if they're real numbers it makes sense - among them, there are sometimes round numbers like 0 and 1 that appear in a dataset more often than other numbers. This could be useful information.

janezd commented 2 years ago

Showing mode for numeric variables is trivial. How would it look in the output? Current output variable 'mode' is a string variable because it contains values of different variables (which is what #6185 was mostly about). If this same variable also contained mode for numeric variables, they would be strings? Or would it again be a separate column? @lanzagar?

Screen Shot 2022-10-14 at 18 41 48

As for the second warning: after introducing decorators for deferred commits, I changed almost all widgets to use them (#5495). I remember skipping this one, but forgot to document the reason. It could have been that I'd like to avoid recommitting output "Statistics" if only "Reduced Data" has changed. I'l look into it.