biolab / orange3

🍊 :bar_chart: :bulb: Orange: Interactive data analysis
https://orangedatamining.com
Other
4.81k stars 1k forks source link

Concatenate: adjust description in Variable matching or allow matching variables with different roles #6839

Open wvdvegte opened 3 months ago

wvdvegte commented 3 months ago

What's wrong? The first option for Variable matching is described as "Treat variables with the same name as the same variable, even if they are computed using different formulae" where it should actually be "Treat variables with the same name and the same role as the same variable, even if they are computed using different formulae". If inputs have variables with the same name but different roles (e.g. feature in one input and meta in another) they will be renamed and appear in separate columns. A user may not always be interested in upstream assignment (and alignment) of roles. In that case, it can be hard to find out why the variables with the same name are not treated as the same variable. Therefore, either "and the same role" should be added to the option description, or the matching in Concatenate should be tolerant to differences in role and convert all roles to a default (for instance: if the role is different, the matching always results in a meta variable - which can always be adjusted downstream)

What's your environment?