biolink / biolink-model-toolkit

A collection of useful python functions for looking up information and working with the Biolink Model
https://biolink.github.io/biolink-model-toolkit/
BSD 3-Clause "New" or "Revised" License
20 stars 11 forks source link

Optionally provide aliases with get_descendants(), etc. #54

Closed patrickkwang closed 2 years ago

patrickkwang commented 3 years ago

This is motivated by the desire to receive biolink:ChemicalSubstance as a descendant of biolink:NamedThing, for backwards compatibility.

cmungall commented 2 years ago

I'm tending against this. I think we should make it very easy for people to compose two calls together, e.g.

The caller can then implement any logic they need for edge cases, e.g

I think the core lib could become bloated if we try and anticipate every possible use case and way functions can be combined

This would be great for a UI though

I could be persuaded to have something like this in a kind of supplemental grab-bag utility library that wraps a simpler core lib

I may be being a too pedantic computer scientist though so if there is strong need for this we can add (I am guessing not though given I assume this was August!)

sierra-moxon commented 2 years ago

closing for now. please reopen if you would like us to reconsider @patrickkwang :)