biolink / biolink-model

Schema and generated objects for biolink data model and upper ontology
https://biolink.github.io/biolink-model/
Other
177 stars 73 forks source link

Add a predicate specifically for structural relationships between molecular structures #430

Closed RichardBruskiewich closed 3 years ago

RichardBruskiewich commented 4 years ago

Scientific issue motivating this feature request:

Possible solution:

Add a new Biolink Model predicate?

  structurally related to:
    is_a: related to
    description: holds between two molecular entities which have highly correlated primary chemical structures
    domain: molecular entity
    range: molecular entity
    exact_mappings:
      -
    broad_mappings:
      -
    narrow_mappings:
      # sample narrow mappings borrowed from S. Ramsey's recent curation of RTX... There may be others?
      - CHEBI:has_parent_hydride
      - CHEBI:is_conjugate_acid_of
      - CHEBI:is_conjugate_base_of
      - CHEBI:is_enantiomer_of
      - CHEBI:is_tautomer_of

Origin of this request:

The need for this change suggested by ongoing data modeling discussions about representing chemical similarities in the Biolink and some attempted mappings of chemical predicates (e.g. from CHEBI) to the model.

Relevant members for discussion @cmungall, @cbizon, Steve Ramsay, Vlado Dancik

cbizon commented 4 years ago

Would this be a child of a proposed similar_to predicate? (see https://github.com/biolink/biolink-model/pull/404)

RichardBruskiewich commented 4 years ago

Hi @cbizon, sure.. that sounds reasonable. Perhaps the name of the slot could also be tweaked to read structurally similar to? Do we need to add any reference to chemistry in the name, i.e. chemical structure similar to to be more precise? Or molecular structure similar to (to better align with the associated domain and range category names)?

vdancik commented 4 years ago

add label: chemical

RichardBruskiewich commented 4 years ago

Hi @vdancik, what did you specifically have in mind? Are you thinking of biolink:chemical_structure_similar_to? I just realised that after previously revisiting this issue, I followed @cbizon's link over to https://github.com/biolink/biolink-model/pull/404 which added "biolink:chemically_similar_to", which was just merged.

That said, there was mention in that PR of an additional refinement of chemistry semantics:

structurally similar to  # could also simply be 'chemical structure similar to'?
    is_a chemically similar to
          is_a similar to
              is_a related to

Vlado, do you think that any further chemistry refinement of biolink terms would be useful, e.g. a term chemical structure similar to plus other related chemistry terms, e.g. predicates like chemical ion form of, chemical radical of or chemical salt of (perhaps others)?

vdancik commented 4 years ago

@RichardBruskiewich I had in mind add github label "chemical" to this issue.

nlharris commented 3 years ago

Is this covered by the chemical entity refactoring that @vdancik is working on? Seems like it should not be assigned to @cbizon?

sierra-moxon commented 3 years ago

@vdancik @RichardBruskiewich - I'm going to close this issue for now as it appears that Richard and Chris B handled at least the basic use case in #404. Please do reopen if I got this wrong! :)