biolink / biolink-model

Schema and generated objects for biolink data model and upper ontology
https://biolink.github.io/biolink-model/
Other
177 stars 73 forks source link

DRKG predicate mappings #662

Open schatzkara opened 3 years ago

schatzkara commented 3 years ago

As part of a research project, I am using DRKG (The Drug Repurposing Knowledge Graph) and am hoping to map it to biolink so that I can do some analysis comparing DRKG and ROBOKOP.

Would it be possible to add predicate mappings for the relations in DRKG that are not already mapped? They are listed below.

@balhoff

cmungall commented 3 years ago

Can you help us understand the format?

Are these lists of actual predicates

I am not sure how to intrepret:

GNBR::E+::Compound:Gene GNBR::E+::Gene:Gene GNBR::E-::Compound:Gene GNBR::E::Compound:Gene

schatzkara commented 3 years ago

Yes, of course. Sorry I should have added this to the initial issue. The format is: source::predicate::connected_entity_type1:connected_entity_type2

Specifically, the ones that you mentioned come from GNBR which uses the following key for the predicate types. GNBR Predicate Key

The predicates from Hetionet are similarly confusing and are defined by the following key: Hetionet Predicate Key

DRKG also provides some (limited) descriptions and interaction types for the predicates, which is in the attached file. relation_glossary.zip

sierra-moxon commented 3 years ago

@schatzkara - I imagine we'd use full predicate names like 'agonism' vs. 'A+' (we could potentially add things like 'A+' as an alias? - would this work?)

schatzkara commented 3 years ago

Yes, full names would definitely be fine as opposed to the far less readable acronyms :)

mbrush commented 3 years ago

Note that some of these predicates fall into the 'interaction mechanism' category, which the Chemical WG is working to harmonize. so work on these should be seeded to / coordinated with them.

Their working s/s is HERE. Note that GNBR is not one of the sources they targeted for harmonization - so we should be sure to add the GNBR interaction mechanism terms to the harmonization s/s . I added a stub sheet to the doc with a link to the GNBR predicate list.

sierra-moxon commented 3 years ago

Thanks @mbrush! Work added on Matt's spreadsheet: https://docs.google.com/spreadsheets/d/1VI2s5YVDwOHiQv7hBWkl12d86yWvm-z_pDJFnDwsoiY/edit#gid=542956250

sierra-moxon commented 3 years ago

tagging @ericawood as she had a ticket that was very similar here: #679

nlharris commented 3 years ago

Can this be closed?

sierra-moxon commented 3 years ago

@schatzkar, I believe much of this case is handled by this PR (refactoring the chemical hierarchy). Would your team have a chance to review that PR with regard to this ticket? I've attached this ticket there, so that when the PR is merged, this ticket will be resolved.

schatzkara commented 3 years ago

@schatzkar, I believe much of this case is handled by this PR (refactoring the chemical hierarchy). Would your team have a chance to review that PR with regard to this ticket? I've attached this ticket there, so that when the PR is merged, this ticket will be resolved.

@sierra-moxon It looks like some of the DRUGBANK predicates and several of the Hetionet predicates are covered there, but some others are not. I did not see the GNBR, INTACT, STRING, or bioarx predicates there. I can give a more specific list if that's what you're looking for. Maybe the rest do not fit into the ontology?