search

biolink / biolinkml

DEPRECATED: replaced by linkml
https://github.com/linkml/linkml
Creative Commons Zero v1.0 Universal
23 stars 12 forks source link

SchemaLoader doesn't raise error for slots with both a key and identifier #102

Closed jiaola closed 3 years ago

jiaola commented 4 years ago

When parsing a file with slots having both a key and identifier, it needs to raise the value exception catching it. See https://github.com/biolink/biolinkml/blob/master/tests/test_utils/input/loadererror8.yaml and https://github.com/biolink/biolinkml/blob/master/tests/test_utils/input/loadererror9.yaml

jiaola commented 4 years ago

The testcase is at https://github.com/biolink/biolinkml/blob/master/tests/test_utils/test_schemaloader.py, see function test_key_and_id

hsolbrig commented 4 years ago

Note that issue #211 will be dropping "key" from the model completely