search

biolink / biolinkml

DEPRECATED: replaced by linkml
https://github.com/linkml/linkml
Creative Commons Zero v1.0 Universal
23 stars 12 forks source link

WIP fix for yuml #144

Closed cmungall closed 4 years ago

cmungall commented 4 years ago

See #118

hsolbrig commented 4 years ago

I don't think that this will work -- the bar ('|') replacement only applies when embedding yuml URL's in markdown or html. If you use it as a direct URL, you get an error.

We have a proposed alternative in the test_fixes branch that passes all the unit tests. Can we double check whether this works everywhere and, if not, can we get a unit test in to validate it.

Also, why did we decided to embed URL's in the biolink_model markdown vs. create an images directory? Past experience has shown that dynamic yuml diagram generation can interfere with browsing.

hsolbrig commented 4 years ago

Hopefully this is now fixed in the main branch -- can you check to see whether there are any remaining issues?