biolink / biolinkml

DEPRECATED: replaced by linkml
https://github.com/linkml/linkml
Creative Commons Zero v1.0 Universal
23 stars 12 forks source link

Documentation generation has odd results (domain inducement resurfacing?) #178

Closed cmungall closed 4 years ago

cmungall commented 4 years ago

See https://cmungall.github.io/dasher/MetricResult.html

Inherited from download problem:
has source OPT
range: KnowledgeSource

Inherited from problem:
description OPT
Description: A description
range: String

but this class does not inherit from anything!

This is once again a resurfacing of the error where slots had induced domains; in this case has_source

 metric result:
    description: >-
      Result of executing a metric on a KS
    slots:
      - evaluated using
      - has source
      - has status
      - description
      - has messages

  problem:
    description: >-
      An object representing an error or problem encountered
    slots:
      - description

  download problem:
    is_a: problem
    description: >-
      A problem in downloading a knowledge source
    slots:
      - has source
hsolbrig commented 4 years ago

I think this is a markdown generation error, not the reappearance of the domain issue -- we would have hit other unit tests were that the case. Will check

hsolbrig commented 4 years ago

Made a significant model change to cover this. Added domain_of to the slot definition, which carries in it all classes that explicitly reference the slot. Updated slot domain attribute so that it ONLY reflects what is declared in the slot. Deprecated owner, although there is still some code that will require work before it goes away. For good. Will add another low priority issue to cover this.