Updating `jsonlines` dependecy version. - Githubissues

biolink / kgx

KGX is a Python library for exchanging Knowledge Graphs

https://kgx.readthedocs.io

BSD 3-Clause "New" or "Revised" License

114 stars 26 forks source link

Updating `jsonlines` dependecy version. #480

Closed hrshdhgd closed 5 months ago

hrshdhgd commented 5 months ago

Reason:

ODK:
- kgx and oaklib are dependencies.
- oaklib happens to use ^4.0.0 and kgx has it at ^3.1.0 (which implies (<4.0.0). Because of this the dependencies do not get resolved and:
  - poetry complains
  - ODK uses requirements.txt which autogenerates constraints.txt which basically anchors package versions to exact x.x.x . Due to this kgx version that gets installed is 1.7.2. I don't know why or how (my naive guess is jsonlines was not a dependency for that version?)
  - This PR is my test to see if this is the reason plus it doesn't hurt to update a package if it doesn't break anything.

caufieldjh commented 5 months ago

Should be fine. Newer version of jsonlines doesn't support Python 3.7 but we're already requiring 3.9 or above for kgx, so no issues there.