biomedicalinformaticsgroup / Sargasso

Sargasso disambiguates mixed-species high-throughput sequencing data.

http://biomedicalinformaticsgroup.github.io/Sargasso/

Other

8 stars 4 forks source link

Inconsistent use of mismatches in thresholds #56

Closed lweasel closed 6 years ago

lweasel commented 6 years ago

In hits_checker.py , the method check_hits() compares the maximum number of mismatches for a set of mappings for a read against the mismatch threshold. But _check_thresholds compares the minimum number of mismatches against the threshold. I think that these should both use the minimum number of mismatches?

hxin commented 6 years ago

in the branch but need to be tested to see the effect.

59

The continuous-integration check fails but this is expected since the desition making structure has been changed.