biomedontology / idobru

IDOBRU: Brucellosis Ontology
0 stars 2 forks source link

Re-engineering Request on children of Brucellosis Infectious Disease Endemic Site/Free #5

Open johnbeve opened 4 years ago

johnbeve commented 4 years ago

The class brucellosis infectious disease endemic site has children classes several countries: Albania, Spain, etc. That suggests, say, Albania is always a brucellosis infectious disease endemic site, which is not exactly accurate. Ontobee, moreover, indicates these children classes are imported from IDO, but I can't locate these children defined in the linked IDO owl file or elsewhere.

Generally speaking, the class country is a subclass of geopolitical entity which is a subclass of site. Importantly though, Albania isn't a type of country, but is an instance of country. So I don't think there should be a class for it.

To capture the intended meaning, it might be better to keep brucellosis infectious disease endemic site and use the BFO relation located in, i.e. an instance of brucellosis infectious disease endemic site is located in the instance of country that is Albania.

Similar remarks apply to brucellosis free sites, described as those declared free of brucellis at some point.

linikujp commented 4 years ago

This is a good point. And I think there will be some temporal parts for this as well.
A country is a polical entity, because the geographical region which covers will vary in history. Just for convenience, we are making the country as instance. I think this topic deserves more thoughts.

linikujp commented 4 years ago

Will change the counties to instances. - todo by Asiyah [Per meeting on 5/19/2020 with John B., Shane B., Asiyah L. and Oliver H.]