search

biomejs / biome-zed

Biome extension for Zed
https://biomejs.dev
MIT License
127 stars 4 forks source link

Does not work well with TSX files #1

Closed chungweileong94 closed 5 months ago

chungweileong94 commented 5 months ago

Not sure if this is a Zed language server bug, All the TSX files in the project don't seem to work properly. I ran biome check ., it's all good.

image

jackTabsCode commented 5 months ago

I'm getting these kinds of errors in TypeScript files too.

luckydye commented 5 months ago

I have seen this too. Weird part is, it does work fine as a dev extension. Need to investigate...

luckydye commented 5 months ago

I suspect its because the extension api for language_ids is not yet included with the stable release, which it seems the extensions are packaged with. It is included with zed v0.130.x, so waiting for v0.130 release is probably the solution here.

This extension will need some time to mature, since extensions are so new to zed too.

jackTabsCode commented 5 months ago

I tried the extension on the preview release and it is not working as intended and hallucinating about not being TypeScript

On Sun, Apr 7, 2024 at 2:10 PM, Tim Havlicek @.***(mailto:On Sun, Apr 7, 2024 at 2:10 PM, Tim Havlicek < wrote:

I suspect its because the extension api for language_ids is not yet included with the stable release, which it seems the extensions are packaged with. It is included with zed v0.130.x, so waiting for v0.130 release is probably the solution here.

This extension will need some time to mature, since extensions are so new to zed too.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

chungweileong94 commented 5 months ago

Weird part is, it does work fine as a dev extension.

Yeah, I was able to get it to run properly as dev extension for some reason. Most probably a bug when Zed is trying to build the extension on production.

chungweileong94 commented 5 months ago

After some digging, it looks like the extension doesn't get packaged properly. If you view the ~/Library/Application Support/Zed/extensions/installed/biome/extension.toml, all the language_ids are not part of it, and manually add them in will fix the issue.

image

luckydye commented 5 months ago

This will be fully fixed with v0.0.2. See https://github.com/zed-industries/zed/pull/10293 Just waiting for at least pre-release.