biomejs / biome-zed

Biome extension for Zed
https://biomejs.dev
MIT License
93 stars 2 forks source link

JSON format stop working after adding `"source.organizeImports.biome": true` #26

Open chungweileong94 opened 3 weeks ago

chungweileong94 commented 3 weeks ago

The JSON format stop working after enabling the organize import options:

"code_actions_on_format": {
     "source.organizeImports.biome": true
}

https://github.com/biomejs/biome-zed/assets/15154097/ff5b5630-3632-46c7-8da6-8610d364883e


System Spec

Zed: v0.142.3 (Zed Preview) OS: macOS 14.5.0 Memory: 16 GiB Architecture: aarch64 Biome: 1.8.3

chungweileong94 commented 3 weeks ago

Haven't spend too much time on debugging the issue, but it could be the code action is not working correctly in the latest Zed preview.

beckend commented 2 weeks ago

Workaround:

{
  "languages": {
    "JSON": {
      "code_actions_on_format": {
        "source.organizeImports.biome": false
      }
    },
    "JSONC": {
      "code_actions_on_format": {
        "source.organizeImports.biome": false
      }
    }
  }
}
chungweileong94 commented 2 weeks ago

Workaround:

{
  "languages": {
    "JSON": {
      "code_actions_on_format": {
        "source.organizeImports.biome": false
      }
    },
    "JSONC": {
      "code_actions_on_format": {
        "source.organizeImports.biome": false
      }
    }
  }
}

Ah good idea!