search

biomejs / biome-zed

Biome extension for Zed
https://biomejs.dev
MIT License
127 stars 4 forks source link

Svelte Files get wrecked #27

Closed ZeroPie closed 1 month ago

ZeroPie commented 2 months ago

Seems the HTML get's purged. https://github.com/biomejs/biome-zed/assets/8741666/54bd4c63-97ab-46ab-9ee5-349e733a3e04

ematipico commented 2 months ago

Yikes, I thought that was fixed. This is an issue that belongs to core. Suppose you're doing formatting via stdin?

ZeroPie commented 2 months ago

hi emat,

i hope i am hehe, this is how my config looks like: 

  "languages": {
      "TypeScript": {
        "language_servers": ["biome", "!typescript-language-server", "!eslint"]
      }
  },
  "formatter": {
    "external": {
      "command": "/Users/zp/.bun/bin/biome",
      "arguments": [
        "format",
        "--write",
        "--stdin-file-path",
        "{buffer_path}"
      ]
    }
  },

Just assumed is the plugin since

biome format +page.svelte

didn't do that.

but could Zed be doing something additional to cause this?

ematipico commented 1 month ago

I believe Zed is at fault here. Other clients work correctly (VScode, IntelliJ), and our tests seems to return the correct output: https://github.com/biomejs/biome/blob/main/crates/biome_cli/tests/snapshots/main_cases_handle_svelte_files/format_stdin_write_successfully.snap?plain=1