biomejs / biome-zed

Biome extension for Zed
https://biomejs.dev
MIT License
169 stars 6 forks source link

End of file error in `settings.json` #28

Closed MatteoGauthier closed 4 months ago

MatteoGauthier commented 4 months ago

In settings.json file for configuring zed all the lines are erroring

image

ematipico commented 4 months ago

Zed treats that file as JSONC, but not Biome. You'll have to configure Biome to treat that file as a JSONC: https://biomejs.dev/reference/configuration/#jsonparserallowcomments

luckydye commented 4 months ago

Actually this should be fixed, what Zed version is this?

chungweileong94 commented 4 months ago

Actually this should be fixed, what Zed version is this?

Yeah, not sure which versions, maybe 1.443.0+, Zed will tell Biome to treat the file as JSONC. But we still need to define the settings in biome.json in order for the formatter to work.

luckydye commented 4 months ago

I'll close it as fixed for now. If you still see this, check if the file language is set to "JSONC" in the bottom right of zed.