search

biomejs / biome-zed

Biome extension for Zed
https://biomejs.dev
MIT License
169 stars 6 forks source link

fix: use .exe extension for Windows platform #49

Closed jackTabsCode closed 1 month ago

jackTabsCode commented 1 month ago

Closes #48 Not tested because I can't seem to get installing dev extensions to work on Windows.

ramipellumbi commented 1 month ago

Biome fails to start on windows and this would be a huge addition. To get it to work on windows you need to install cmake (recent change to building) and have it in path. See: https://zed.dev/docs/development/windows

An issue on windows now is (with config path set manually to be correct)

Language server error: biome

failed to spawn command. path: "C:Users\\RamiPellumbi\\Documents\\code\\project\\node_modules\\@biomejs\\biome\\bin\\biome", working directory: "C:\\Users\\RamiPellumbi\\Documents\\code\\project", args: ["lsp-proxy"]
-- stderr--

Note the missing \\ after C:. I think this would be an awesome fix