search

biomejs / website

Biome's website
https://biomejs.dev
MIT License
22 stars 41 forks source link

fix: graphql format output type #644

Closed Sec-ant closed 1 week ago

Sec-ant commented 1 week ago

Summary

Fix a type issue that may break the playground.

netlify[bot] commented 1 week ago

Deploy Preview for biomejs ready!

Name Link
Latest commit 02ea77d20a6bb589501e99d7150bb3665a1fe705
Latest deploy log https://app.netlify.com/sites/biomejs/deploys/66753eb1e477b40008b4acd2
Deploy Preview https://deploy-preview-644--biomejs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ematipico commented 1 week ago

I was looking at that and wondered why the type is any.

We have two options:

Sec-ant commented 1 week ago

I was looking at that and wondered why the type is any.

We have two options:

  • we make the workspace_types.rs better
  • we change the types returned by those functions to match what returned by the other functions

Honestly I had no idea how the types are generated 😓. But I think the first option is better because of no breaking changes. Only the outputs of the format functions are not typed.