biometrics / openbr

Open Source Biometrics, Face Recognition
www.openbiometrics.org
Other
2.84k stars 773 forks source link

Is this an error in comments or in program? #521

Open ghost opened 7 years ago

ghost commented 7 years ago

Hi!

Could you tell me where is the mistake. I walking throw the code: https://github.com/biometrics/openbr/blob/master/app/examples/face_recognition.cpp

and I got results like:

S354-01-t10_01.jpg eyes: (225, 243) (316, 246) S382-08-t10_01.jpg eyes: (195, 253) (287, 256) S354-02-t10_01.jpg eyes: (241, 256) (319, 260) Genuine match score: 3,658 Impostor match score: 0,494

but comment for "printf()" line says that: // Scores range from 0 to 1 and represent match probability

Where is the true?

jklontz commented 7 years ago

This is an error in the comment, which needs to be updated. We allow scores outside the 0 to 1 range now.