search

biometry / bipartite

repository for the bipartite R-package for network analysis
37 stars 17 forks source link

change print() for message() #1

Closed efcaguab closed 7 years ago

efcaguab commented 8 years ago

the use of 'print' in this context is bad practice

cdormann commented 8 years ago

Dear Fernando, many thanks for your email and corrections.

I made the two changes accordingly (without pull).

Cheers,

Carsten

On 08 Feb 2016, at 12:06, Fernando Cagua notifications@github.com wrote:

the use of 'print' in this context is bad practice

You can view, comment on, or merge this pull request online at:

https://github.com/biometry/bipartite/pull/1 https://github.com/biometry/bipartite/pull/1 Commit Summary

change print() for message(), the use of 'print' in this context is bad practice File Changes

M bipartite/R/nestedcontribution.R https://github.com/biometry/bipartite/pull/1/files#diff-0 (2) Patch Links:

https://github.com/biometry/bipartite/pull/1.patch https://github.com/biometry/bipartite/pull/1.patch https://github.com/biometry/bipartite/pull/1.diff https://github.com/biometry/bipartite/pull/1.diff — Reply to this email directly or view it on GitHub https://github.com/biometry/bipartite/pull/1.

— — — — — — Carsten Dormann

Professor of Biometry and Environmental System Analysis Faculty of Environment and Natural Resources University of Freiburg Tennenbacher Str. 4 79106 Freiburg

Tel.: 0049 (0)761 203-3750 Fax.: 0049 (0)761 203 3751 Email: carsten.dormann@biom.uni-freiburg.de

efcaguab commented 8 years ago

Great!

On Wed, 10 Feb 2016 at 09:24 cdormann notifications@github.com wrote:

Dear Fernando, many thanks for your email and corrections.

I made the two changes accordingly (without pull).

Cheers,

Carsten

On 08 Feb 2016, at 12:06, Fernando Cagua notifications@github.com wrote:

the use of 'print' in this context is bad practice

You can view, comment on, or merge this pull request online at:

https://github.com/biometry/bipartite/pull/1 < https://github.com/biometry/bipartite/pull/1> Commit Summary

change print() for message(), the use of 'print' in this context is bad practice File Changes

M bipartite/R/nestedcontribution.R < https://github.com/biometry/bipartite/pull/1/files#diff-0> (2) Patch Links:

https://github.com/biometry/bipartite/pull/1.patch < https://github.com/biometry/bipartite/pull/1.patch> https://github.com/biometry/bipartite/pull/1.diff < https://github.com/biometry/bipartite/pull/1.diff> — Reply to this email directly or view it on GitHub < https://github.com/biometry/bipartite/pull/1>.

— — — — — — Carsten Dormann

Professor of Biometry and Environmental System Analysis Faculty of Environment and Natural Resources University of Freiburg Tennenbacher Str. 4 79106 Freiburg

Tel.: 0049 (0)761 203-3750 Fax.: 0049 (0)761 203 3751 Email: carsten.dormann@biom.uni-freiburg.de

— Reply to this email directly or view it on GitHub https://github.com/biometry/bipartite/pull/1#issuecomment-182046133.