biomimetics / bml_tools

0 stars 3 forks source link

Telemetry import moved to function. Usage examples need updating and checking. #2

Closed apullin closed 10 years ago

apullin commented 10 years ago

Latest commits added telemetryImport.py . This moves all of the parsing code that was at the top of telemetry_plotter.ipynb into a separate file. the telemetryImport(filename) function returns a TelemetryData class.

An ipynb is provided as a usage example, telemetry_plot_example.ipynb. This may be equivalent to the existing telemetry_plotter.ipynb, just with the import method changed to use the new external function.

This example needs to be checked that it properly replicates the example usage. TODO: @ronf-ucb

ronf-ucb commented 10 years ago

Check out the test cases in the update. Something is not getting read correctly, as the torque is not the same with the same PWM and back emf. Haven't added neg PWM case yet to code.

I probably won't look at until tomorrow.

Thanks Ron

On 9/26/2014 5:42 PM, Andrew wrote:

Latest commits added telemetryImport.py . This moves all of the parsing code that was at the top of telemetry_plotter.ipynb into a separate file. the telemetryImport(filename) function returns a TelemetryData class.

An ipynb is provided as a usage example, telemetry_plot_example.ipynb. This may be equivalent to the existing telemetry_plotter.ipynb, just with the import method changed to use the new external function.

This example needs to be checked that it properly replicates the example usage. TODO: @ronf-ucb https://github.com/ronf-ucb

— Reply to this email directly or view it on GitHub https://github.com/biomimetics/bml_tools/issues/2.

apullin commented 10 years ago

Do we need both "example_imudata.txt" and "power-test.txt" ?

ronf-ucb commented 10 years ago

power_test should be fine w/o the other example. Thanks Ron

On 09/29/2014 12:17 PM, Andrew wrote:

Do we need both "example_imudata.txt" and "power-test.txt" ?

— Reply to this email directly or view it on GitHub https://github.com/biomimetics/bml_tools/issues/2#issuecomment-57213313.