search

biomodhub / biomod2

BIOMOD is a computer platform for ensemble forecasting of species distributions, enabling the treatment of a range of methodological uncertainties in models and the examination of species-environment relationships.
85 stars 22 forks source link

Inaccurate warning message in bm_ModelingOptions() #402

Open Farewe opened 8 months ago

Farewe commented 8 months ago

Hello biomod team,

Just a quick notification on the warning that is issued when using bm_ModelingOptions() on the names of runs for which model parameters are customised.

The warning message guesses names based on the number of columns (see the associated code on this link), but the message is inappropriate if there are, for example, multiple PA runs, or if the user chooses to make CV runs + full models.

This is an example of what I am seeing when I model 3 runs of PA with 3 runs of CV: Messages d'avis : 1: Dans .BIOMOD.options.dataset.check.args(strategy = strategy, user.val = user.val, : Options will be changed only for a subset of datasets (_PA1_RUN1, _PA1_RUN2, _PA1_RUN3, _PA2_RUN1, _PA2_RUN2, _PA2_RUN3, _PA3_RUN1, _PA3_RUN2, _PA3_RUN3) and not the others (_allData_RUN1, _allData_RUN2, _allData_RUN3, _allData_RUN4, _allData_RUN5, _allData_RUN6, _allData_RUN7, _allData_RUN8, _allData_RUN9, _allData_allRun, _PA1_RUN4, _PA1_RUN5, _PA1_RUN6, _PA1_RUN7, _PA1_RUN8, _PA1_RUN9, _PA1_allRun, _PA2_RUN4, _PA2_RUN5, _PA2_RUN6, _PA2_RUN7, _PA2_RUN8, _PA2_RUN9, _PA2_allRun, _PA3_RUN4, _PA3_RUN5, _PA3_RUN6, _PA3_RUN7, _PA3_RUN8, _PA3_RUN9, _PA3_allRun).

I would suggest to remove this warning altogether from here, and rather put it in the BIOMOD_Modeling() function, where there could be a check in the compatibility of BIOMOD_Modeling() arguments with the content of OPT.user.val.

MayaGueguen commented 2 months ago

Hello Boris,

Thanks for the feedback ! :pray:

Actually, I kept it for a while on my todo-list. And then finally made a change that should have reduced considerably and more appropriately these warning mesages :eyes: But forgot to mention it to you :see_no_evil: Sorry for that.

Maya