bionanoimaging / FourierTools.jl

Tools for working with Fourier space.
https://bionanoimaging.github.io/FourierTools.jl/stable/
MIT License
54 stars 6 forks source link

Fourier join fix #30

Closed RainerHeintzmann closed 1 year ago

RainerHeintzmann commented 1 year ago

I introduced a recursive type scheme. This seems to work now and the @report_opt seems to be happy, but there may be a cleaner or simpler way to achieve type stability. Felix, can you do some speed test of the old and new scheme before merging?

codecov-commenter commented 1 year ago

Codecov Report

Merging #30 (69a9b59) into main (000735e) will increase coverage by 0.07%. The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   93.26%   93.34%   +0.07%     
==========================================
  Files          17       17              
  Lines         936      947      +11     
==========================================
+ Hits          873      884      +11     
  Misses         63       63              
Impacted Files Coverage Δ
src/correlations.jl 90.00% <ø> (ø)
src/czt.jl 100.00% <ø> (ø)
src/fftshift_alternatives.jl 100.00% <ø> (ø)
src/fourier_filtering.jl 70.58% <ø> (ø)
src/nfft_nd.jl 90.00% <ø> (ø)
src/resampling.jl 91.59% <ø> (ø)
src/utils.jl 100.00% <ø> (ø)
src/custom_fourier_types.jl 100.00% <100.00%> (ø)
src/fourier_resizing.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

roflmaostc commented 1 year ago

Thanks for that.

Did you check for type instabilities? With JET?

roflmaostc commented 1 year ago

See here: https://github.com/bionanoimaging/FourierTools.jl/issues/29

roflmaostc commented 1 year ago

Please revert all the tabbing changes (with a git revert). https://github.com/invenia/BlueStyle#documentation