search

bionanoimaging / FourierTools.jl

Tools for working with Fourier space.
https://bionanoimaging.github.io/FourierTools.jl/stable/
MIT License
54 stars 6 forks source link

fixed a problem with czt which causes wrap-around. This had an effect… #31

Closed RainerHeintzmann closed 1 year ago

RainerHeintzmann commented 1 year ago

fixed a problem with czt which causes wrap-around. This had an effect on resample_czt. There was also a problem with premature clipping when zooming but also extending the destination size. See this examples:

img = Float32.(testimage("resolution_test_512.tif")); resample_czt(img, (0.8,1.6), new_size=(1024,1040))
codecov-commenter commented 1 year ago

Codecov Report

Merging #31 (50f9906) into main (87352d2) will decrease coverage by 0.34%. The diff coverage is 80.76%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   93.34%   93.01%   -0.34%     
==========================================
  Files          17       17              
  Lines         947      959      +12     
==========================================
+ Hits          884      892       +8     
- Misses         63       67       +4
Impacted Files Coverage Δ
src/resampling.jl 90.16% <72.72%> (-1.44%) :arrow_down:
src/czt.jl 96.07% <86.66%> (-3.93%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

roflmaostc commented 1 year ago

As I said before, please always check the docstrings for proper formatting in the REPL. Also check your markdown syntax please. Fixed a couple of mistakes.