Closed roflmaostc closed 9 months ago
Thanks for the fix!
I think the rrule for the planned version is still incorrect. However the adjoints for planned real ffts in Zygote are also incorrect, so just removing the rule won't fix everything (until JuliaMath/AbstractFFTs.jl#67 is released)
Merging #36 (79cd82a) into main (87352d2) will decrease coverage by
0.35%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #36 +/- ##
==========================================
- Coverage 93.34% 93.00% -0.35%
==========================================
Files 17 17
Lines 947 958 +11
==========================================
+ Hits 884 891 +7
- Misses 63 67 +4
Impacted Files | Coverage Δ | |
---|---|---|
src/convolutions.jl | 97.91% <ø> (-0.45%) |
:arrow_down: |
... and 3 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Hi @trahflow,
AD support should be ok, now?