search

bioneos / alcove

Our Unix backup system redesigned with Node.js
ISC License
0 stars 6 forks source link

add fomantic-ui calendar (#77) #98

Closed GautamSharda closed 3 years ago

GautamSharda commented 3 years ago

This integrates the fomantic-ui calendar widget into the machine dashboard addressing issue #77

dominicrutk commented 3 years ago

I think we had a little miscommunication about what I meant by "highlighting" dates to make the calendar continuous.

Screen Shot 2021-07-07 at 10 57 53 AM Screen Shot 2021-07-07 at 10 57 58 AM Screen Shot 2021-07-07 at 10 58 04 AM

In these screenshots, the backup calendar I am using is 0,1,2,3,4,5,6(14)|1(20);[15:46]. In other words, it should keep two weeks worth of daily backups, and a whole bunch of weekly, Monday backups.

Rather than simply making the "overlap" days gray, we should color them like all the other dates. This means the dates with successful backups should be green, unsuccessful red, etc.

One other thing I just noticed is that when increasing the number of weekly backups kept, the calendar does not seem to respond appropriately. I specified 20 weekly backups, which would go a few months before May in these screenshots, but the calendar only seems to go one month back. Make sure you're not hard-coding any assumptions about how many backups the user wishes to keep.

Also, could you add a black outline around the current day on the calendar (like existed in the old version that didn't use Fomantic-UI)? I found that was helpful for quickly identifying the current day.

GautamSharda commented 3 years ago

Due to messy commits, I will create a new PR addressing this issue.

sgdavis1 commented 3 years ago

Be sure to resubmit that request soon @GautamSharda :+1: