search

bionode / bionode-sra

Node.js wrapper for SRA Toolkit
bionode.io
MIT License
6 stars 3 forks source link

Formatting fix and https fix for sra toolkit download #5

Closed amanjeev closed 7 years ago

amanjeev commented 7 years ago

Hi @bmpvieira ! I made some minor changes to the repo. It fails to be installed because the url for SRA toolkit download was http. so I updates the Makefile.

I also formatted the code a bit.

bmpvieira commented 7 years ago

Hey @amanjeev ! Thanks for the PR!! Would you just mind to follow the standardjs.com style?

Cheers, Bruno

amanjeev commented 7 years ago

Sure. Thanks for taking a look. Let me fix that and update the PR. Give me some time though.

amanjeev commented 7 years ago

Sorry it took longer than usual for merely formatting the code. Should be good now. I just used standard --fix.

bmpvieira commented 7 years ago

No problem @amanjeev! One last thing, could you undo the changes to the comments? Those comments are formatted that way and used to generate the documentation with npm run build-docs. Thank you!

amanjeev commented 7 years ago

Sorry about this fiasco! I've reset the entire branch and just made the relevant changes. Now only two commits, what it should have been in the beginning anyway. :)

bmpvieira commented 7 years ago

ahah don't worry, next time will be better! :)

amanjeev commented 7 years ago

Thank you for allowing me to participate!