biopragmatics / bioregistry

📮 An integrative registry of biological databases, ontologies, and nomenclatures.
https://bioregistry.io
MIT License
107 stars 47 forks source link

Update Online Mendelian Inheritance in Animals #1105

Closed ImkeTammen closed 2 months ago

ImkeTammen commented 2 months ago

Prefix

omia

Explanation

  1. Please change the introductory text from: "Online Mendelian Inheritance in Animals (OMIA) is a catalogue/compendium of inherited disorders, other (single-locus) traits, and associated genes and variants in 363 animal species (other than human and mouse and rats and zebrafish, which have their own resources)." to " "Online Mendelian Inheritance in Animals (OMIA) is a catalogue/compendium of inherited disorders, other (single-locus) traits, and associated genes and variants in more than 500 vertebrate animal species (other than human, mouse, rats, zebrafish and western clawed frog, which have their own resources)."

  2. I noted that the Example Local Unique Identifier is given as ‘1000’ – however OMIA uses the following IDs – either OMIA:xxxxxx or OMIA:xxxxxx-yyyy.., where xxxxxx is the 6-digit number for a trait/disorder, and yyyy.. is the NCBI species taxonomy id (usually four digits, but sometimes longer). Should the sample ID in the registry be changed accordingly? Example URL links and corresponding OMIA IDs are: https://www.omia.org/OMIA001000/ for OMIA:001000 https://www.omia.org/OMIA001000/9615/ for OMIA:001000-9615

  3. We have also introduced recently a new ID 'OMIAvariantID:x', where x is a consecutive number starting from 1 and at the moment going up to 1578. These IDs are currently not linked to a public facing URL (URL is only visible to database curators). Can the OMIAvariantID:x be registered with bioregistry or is this only appropriate if the ID can be linked to an URL?

Kind regards,

Imke

Contributor ORCID

0000-0002-5520-6597

bgyori commented 2 months ago

Hi @ImkeTammen, thanks for the suggestions! I just opened a pull request with some changes.

matentzn commented 2 months ago

@ImkeTammen I agree with Ben on

Would it be possible for the OMIA website to be able to resolve e.g., https://www.omia.org/OMIA001000-9615? If so, we could extend the pattern/resolver to this case.

I would also strongly advocate for this to be possible!

Generally when you design identifiers, it is a good idea nowadays to also think of a simple way to resolve this identifier as is to a URL by just appending it:

http://some.url/IDENTIFIER

with:

ImkeTammen commented 2 months ago

Thanks Nico - we will discuss with Marius if that is an option. People have been using the existing URL widely and I don't want to interrupt those connections.

bgyori commented 2 months ago

I think you could still keep the existing URLs working at https://www.omia.org/OMIA001000/9615/ and in addition, implement support for resolving URLs using the pattern https://www.omia.org/OMIA001000-9615. This would solve the issue on both sides!

bgyori commented 2 months ago

I merged the changes for now, we can come back to the remaining issues in separate PRs.