Closed bgyori closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 43.98%. Comparing base (
6092b57
) to head (2aeaba5
). Report is 138 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Given that the Bioregistry primarily aims to curate identifier resources, and from that perspective, GlyGen really is just a provider, I think these changes make sense. The metadata (i.e., publications, maintainer, etc.) associated with the GlyGen entry is useful but not strictly from a prefix / identifier pattern / resolver URL perspective which again is the main focus here.
Hello @jeet-vora, do you have any thoughts on this change?
Just noticed this is still open, @jeet-vora do you have any comments on this?
@bgyori Sorry missed this.
I would keep GlyTouCan and GlyGen as separate entries. GlyTouCan is a repository for glycans and provides IDs for Them. GlyGen is a knowledgebase that provides information about glycans by using the standard GlyTouCan IDs to represent them. GlyGen also has information about genes and proteins that GlyTouCan does not have. GlyGen does not assign glycan IDs.
Again the above suggestion is based on what I know so far. I my suggestion does not make sense or resolve the issue I might have to dig deep into the communication and the information while I was gone.
I think perhaps our use of the word "merging" is a bit misleading. What happens in this PR is that we keep glytoucan
as the prefix curared in Bioregistry for a namespace of identifiers while curating gylgen
as a provider for those identifiers. This, I think, captures what you wrote above.
I see. Thanks Please go ahead as previously planned
This PR merges
glygen
intoglytoucan
while preserving it as a synonym and as a provider for glytoucan IDs. Some issues with this: useful metadata about GlyGen gets lost, for instance its mapping to FairSharing and Integbio, and metadata on a resolver for UniProt IDs on GlyGen.Fixes #1084