biopragmatics / bioregistry

📮 An integrative registry of biological databases, ontologies, and nomenclatures.
https://bioregistry.io
MIT License
115 stars 49 forks source link

Question about information mapped to antibodyregistry prefix #229

Closed bandrow closed 2 years ago

bandrow commented 2 years ago

http://bioregistry.io/registry/rrid

also here https://bioregistry.io/registry/antibodyregistry

Also the Antibody registry has the following syntax that is not being used to resolve: https://antibodyregistry.org/AB_493771

Currently it is using the query= syntax, which is not persistent.

so I am not sure why that is.

tgbugs commented 2 years ago

https://github.com/biopragmatics/bioregistry/blob/92c4879192ec7f0332ad5b18b020ed2756f589e2/src/bioregistry/data/external/prefixcommons/processed.json#L2270-L2272 and https://github.com/biopragmatics/bioregistry/blob/92c4879192ec7f0332ad5b18b020ed2756f589e2/src/bioregistry/data/external/prefixcommons/raw.json#L333

related

bgyori commented 2 years ago

Hi @bandrow, let me try to respond below:

http://bioregistry.io/registry/rrid

  • has no n2t.net resolver in one part, middle, but does have an example where it resolves at the bottom.

also here https://bioregistry.io/registry/antibodyregistry

  • has no n2t.net resolver in one part, middle, but does have an example where it resolves at the bottom.

On the pages linked to above, the middle section is called Metaregistry which links out to pages of registries that contain an entry for antibodyregistry and rrid. For identifiers.org and Prefix Commons there are links out to pages that represent the antibodyregistry and rrid entry respectively. However, Name-to-Thing does not contain a landing page which corresponds to antibodyregistry and rrid overall so creating a link isn't possible. See also the hover text on the info icon next to the entry saying "Name-to-Thing does not resolve metaidentifiers".

In contrast, the bottom section is for Providers which resolve CURIEs and here Name-To-Thing is able to resolve CURIES such as antibodyregistry:493771 so providing the link https://n2t.net/antibodyregistry:493771 is possible.

Also the Antibody registry has the following syntax that is not being used to resolve: https://antibodyregistry.org/AB_493771

Currently it is using the query= syntax, which is not persistent.

The URL pattern for antibodyregistry is set to http://antibodyregistry.org/AB_$1. This is identical to the URL pattern defined in identifiers.org (see the URL Pattern entry in https://registry.identifiers.org/registry/antibodyregistry showing http://antibodyregistry.org/AB_{$id}). It appears that the redirect from e.g., http://antibodyregistry.org/AB_493771 to https://antibodyregistry.org/search.php?q=AB_493771 happens on antibodiregistry.org.

With these in mind, do you think there is anything that needs to be changed?

bgyori commented 2 years ago

I also wanted to explicitly reflect on the issue of having "no way to edit" these entries. In fact, bioregistry.io is built and deployed from the data files publicly available and version controlled in this Github repository. This means that changes can be contributed to any part of the service and the underlying data as pull requests to make extensions or corrections.

bandrow commented 2 years ago

Thank you for your thoughtful answer. I think I understand this a little better. Don’t think anything needs to be changed. Thanks, Anita

bandrow commented 2 years ago

Sure but there is no indication when you go to this site that it can be edited via GitHub. Also there is no edit button so it does not look like there is anything that one can do.

bgyori commented 2 years ago

I agree, it would be great to link directly from the website to opening an issue or allowing editing (though still through the regular Github-based contribution process) from pages for individual registry entries. There are some pages on the website that do this already but we can work towards adding it in more places. Thanks!

cthoyt commented 2 years ago

Interestingly, @jkunze demonstrated on Friday after this issue was written a secret way to get some information about a given resource in N2T by adding a colon at the end but no identifiers. This was addressed in 1ca99a6, so with the next redeployment tonight it will be possible to follow an N2T mapping on a given resource page to the N2T YAML page describing the given resource in N2T. For other registries that don't have web pages for each of their prefixes, I still think the lack of link and hover info text is sufficient

cthoyt commented 2 years ago

Thanks for the feedback @bandrow, I think we were able to make a few updates to reduce any potential future inclusion, and also have a follow-up issue #234. I'll close this one for now, feel free to open up new issues for any future questions