search

biopragmatics / bioregistry

📮 An integrative registry of biological databases, ontologies, and nomenclatures.
https://bioregistry.io
MIT License
120 stars 53 forks source link

Explicitly set MONDO `uri_format` with OBO PURL #916

Closed dhimmel closed 1 year ago

dhimmel commented 1 year ago

Example resolved URL like https://monarchinitiative.org/disease/MONDO:0005301

Noticed this when trying to resolve https://bioregistry.io/MONDO:0002594 and got this redirection:

image

Redirects to http://www.bioregistry.io/0002594 that then says HTTP 404 - Unknown Prefix. So confused about why this redirect happens and likely a bug unrelated to the lack of uri_format.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (074f325) 40.86% compared to head (2cb30b5) 40.86%. Report is 43 commits behind head on main.

:exclamation: Current head 2cb30b5 differs from pull request most recent head b2bc70e. Consider uploading reports for the commit b2bc70e to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #916 +/- ## ======================================= Coverage 40.86% 40.86% ======================================= Files 135 135 Lines 7803 7803 Branches 1809 1809 ======================================= Hits 3189 3189 Misses 4418 4418 Partials 196 196 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cthoyt commented 1 year ago

This is an interesting situation. Most of the OBO Foundry ontologies on Wikidata are encoded totally wrong, with bananas everywhere, causing this issue.

All of the OBO Foundry ontologies should get a OBO PURL as their priority URI format, I will look into this