biopragmatics / bioregistry

📮 An integrative registry of biological databases, ontologies, and nomenclatures.
https://bioregistry.io
MIT License
114 stars 49 forks source link

Externalize prefix map export implementation #972

Closed cthoyt closed 10 months ago

cthoyt commented 10 months ago

Writing EPMs, JSON-LD, and SHACL are now part of the curies package. This PR externalizes them.

It has a small drawback that for SHACL, it now uses the canonical prefix's pattern when that differs from the specific one. To give an example, the kegg prefix has a generic pattern that fits all of its children. The kegg.drug is a subspace of kegg and has a specific pattern. This is no longer captured.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/bioregistry/record_accumulator.py 91.13% <100.00%> (+0.05%) :arrow_up:
src/bioregistry/resource_manager.py 75.23% <ø> (ø)
src/bioregistry/version.py 68.42% <100.00%> (ø)
src/bioregistry/export/prefix_maps.py 0.00% <0.00%> (ø)

:loudspeaker: Thoughts on this report? Let us know!.