Open MarkusPiotrowski opened 8 years ago
How about using /static/css/
and /static/images/
etc where the static
folder is intended for website assets?
The Hyde theme uses /public/css/
etc for this https://github.com/poole/hyde/tree/master/public but I find the folder name less obvious.
HTML5 Up! uses in their designs a folder assets
as parent folder for css
, fonts
etc. which seems even more obvious than static
?
I like assets
too :)
I can work on setting this up in _config.yml file - I believe that is where you define directory locations for various assets .. let me know if you folks would like me to work on this based on above approach
@mgudapak if there's a standard approach using settings in _config.yml
then sure, let's do that.
for the record .. these are the IMAGES we currently have
<repo_root_dir> $ find . -iname "*.png" -o -iname "*.jpg"
./apple-touch-icon-144.png
./biopython_grey.png
./wiki/Biopython.jpg
./wiki/Biopython_small.jpg
./wiki/Contig_class.png
./wiki/Hmm_discrete.png
./wiki/Hmm_discrete_py.png
./wiki/Journal.pcbi.1000406.g002.png
./wiki/Phylo-apaf-node0.png
./wiki/Phylo-apaf.png
./wiki/Phylo-draw-apaf1.png
./wiki/Smcra.png
./wiki/Torus_dbn.png
./wiki/TorusDBN.png
./wiki/Wininst.png
All the images under wiki/
are not assets which are only part of the site layout, but rather part of the contents (originally being uploaded via MediaWiki). Here we do want to preserve the current URL.
Are there any constraints on site icons being at the top level like favicons?
for the record .. these are the CSS files we currently have
<repo_root_dir> $ find . -iname "*.css"
./css/hyde.css
./css/poole.css
./css/syntax.css
@peterjc - got it - i now see the difference between the ones under root to those under 'wiki'. So the goal is to relocate those under root to assets/images
, and the css under ./css to assets/css
.
Did I get it right?
and i will check on the favicons restrictions if any ..
https://github.com/biopython/biopython.github.io/commit/5aea6da78c41e507f7e0599ae9bf7b2195abaaf9 - CSS moved.
https://github.com/biopython/biopython.github.io/commit/ed473aa77a3e4f3b545b6abf0180b91f3a3c6465 - grey background logo moved.
Favicons etc - can we move them?
Currently all these paths are hard coded in _include/*.html
so if there's a conventional way to do this via _config.yml
that would be better (which I think is what @mgudapak was suggesting).
We don't have a real favicon, 'just' the apple-touch-icon
. That works on Android mobiles as icon (when you put a bookmark on the home screen), (and, as I would suggest from the name, on Apple devices), but not as icon in Windows browsers on tabs and as bookmark. Don't now for Linus/Unix browsers. Thus, creating a nice favicon (16*16px!) is maybe another issue, we should raise separately. The actual Biopython logo with it's banner-like dimension is not applicable for downsizing to 16x16px.
I've opened #86 for making a favicon (there is commented out code to use this in the Hyde/Poole template) 16x16 pixels will be a challenge.
https://mathiasbynens.be/notes/touch-icons suggests that the apple-touch-icon
might be best left at the top level (root folder), but I've not confirmed this.
Since we may add some more image files (e.g. transparent Biopython logo, Twitter logo, Github logo....) we should think about putting them together in a folder "images" to keep the root clean.