biorack / blink

Other
8 stars 2 forks source link

Inclusion into matchms #4

Open florian-huber opened 1 year ago

florian-huber commented 1 year ago

Nice that your approach works so much faster than the conventional way of computing Cosine scores, And, most of all, that it seems to work well as a potential pre-filter to select candidates with potentially high cosine scores!

This would obviously be a very nice addition to matchms. I could implement it on the matchms side, but it would need more testing (preferentially right here, otherwise in matchms). Let me know if I can help with setting up tests and continuous integration.

tharwood3 commented 1 year ago

Thanks @florian-huber! Inclusion in matchms would be great. We will build up our testing suite and continuous integration and keep you in the loop.

YUANMENG-1 commented 8 months ago

Excuse me, every time i try the "conda env create -f environment.yml", it will stop in solving environment here in the picture, and finally failed to continue, I remember last year I also met this problem and failed to try blink, and I install all the dependency before running the environment.yml and whether in HPC or mac all met this

image
benbowen commented 8 months ago

Hi @YUANMENG-1, I'm sorry to hear you are having conda trouble. Can you open a new ticket please? This ticket is specific to our long-term goal of getting BLINK into MatchMS.