WIP-refactoring nesting

biosimulators / Biosimulators_COPASI

COPASI biochemical network simulation program via BioSimulators-compliant command-line interface and Docker container

https://docs.biosimulators.org/Biosimulators_COPASI

MIT License

2 stars 3 forks source link

WIP-refactoring nesting #57

Closed AlexPatrie closed 2 months ago

AlexPatrie commented 1 year ago

In an effort to lower the generalized "cognitive complexity" score assessed by SonarCloud, this pr and branch serves as an effort to lower all cognitive complexity-assessments-points > 1 to be <= 0. Please refer to Issue "Lowering Cognitive complexity as per SonarCloud" for more information.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
5 Code Smells

No Coverage information
0.0% Duplication

fbergmann commented 2 months ago

@AlexPatrie @eagmon is this PR still about to be applied? We were informed about the biosimulator not solving simple SBML problems. So I was about to look into this, but would not want to change code if this PR is about to be merged in.

Critically there is an issue merging in the changes for the identifiers.org parts, where you are planing to commit a change from

http://identifiers.org/combine.specifications/sbml

https://identifiers.org/combine.specifications/sbml

this should not happen, since http://identifiers.org/combine.specifications/sbml is a namespace, and the https version would be a different namespace. So if this PR is going to merge, then that should not be merged in.

AlexPatrie commented 2 months ago

@AlexPatrie @eagmon is this PR still about to be applied? We were informed about the biosimulator not solving simple SBML problems. So I was about to look into this, but would not want to change code if this PR is about to be merged in.

Critically there is an issue merging in the changes for the identifiers.org parts, where you are planing to commit a change from
http://identifiers.org/combine.specifications/sbml
to
https://identifiers.org/combine.specifications/sbml
this should not happen, since http://identifiers.org/combine.specifications/sbml is a namespace, and the https version would be a different namespace. So if this PR is going to merge, then that should not be merged in.

Hi @fbergmann! This is an outdated PR that I should have originally archived. Please feel free to do whatever work you need here. I will be closing this PR.